Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNOME Shell theme #20

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Add GNOME Shell theme #20

merged 4 commits into from
Jul 28, 2022

Conversation

ashbork
Copy link
Contributor

@ashbork ashbork commented Jul 17, 2022

The shell theme's author allowed for their theme to be used here! This resolves #8 (though not all variants are included yet but I'm sure that can be done fairly easily with build.

@ashbork
Copy link
Contributor Author

ashbork commented Jul 17, 2022

Wow this commit history is a mess, I tried squashing but that doesn't seem to have helped

@mvllow
Copy link
Member

mvllow commented Jul 17, 2022

No worries on the commit history, we can squash on merge 😌 If @ThatOneCalculator has time I'll ask them to review the PR since I don't understand most of this gtk stuff 😭

@ashbork
Copy link
Contributor Author

ashbork commented Jul 17, 2022

I don't quite understand it myself, it seems to just be css but it's generated somehow, I'd love to see a tool that'd do it more easily (I had to edit the files manually to change the things I didn't quite like)

@ThatOneCalculator
Copy link
Member

I can't quite test it out since I don't use GNOME, it looks fine structurally, but I'll need to set up a VM/machine with GNOME to test it.

@mvllow
Copy link
Member

mvllow commented Jul 21, 2022

I can't quite test it out since I don't use GNOME, it looks fine structurally, but I'll need to set up a VM/machine with GNOME to test it.

That would be appreciated but don't feel like you need to 😌 If you want to merge as-is that's definitely fine too!

@mvllow
Copy link
Member

mvllow commented Jul 28, 2022

Trusting @zoedsoupe approval because they like functional programming :)

@mvllow mvllow merged commit af7897d into rose-pine:main Jul 28, 2022
@zoedsoupe
Copy link

Oh gosh, that's a huge responsibility haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shell theme
4 participants