Skip to content

Disable Connext security tests on Windows #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobperron merged 2 commits into from
Jun 1, 2020
+3 −2
Merged

Disable Connext security tests on Windows #433

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d25332
Disable Connext security tests on Windows
jacobperron May 27, 2020
cdd83f8
Use parentheses
jacobperron May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test_security/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,10 @@ if(BUILD_TESTING)
endif()

# TODO(mikaelarguedas) only Connext and FastRTPS support DDS-Security for now
# TODO(jacobperron) Disable Connext on Windows until we fix issue with CI
if(
rmw_implementation STREQUAL "rmw_connext_cpp" OR
rmw_implementation STREQUAL "rmw_connext_dynamic_cpp" OR
rmw_implementation STREQUAL "rmw_connext_cpp" AND NOT WIN32 OR
rmw_implementation STREQUAL "rmw_connext_dynamic_cpp" AND NOT WIN32 OR
Comment thread
jacobperron marked this conversation as resolved.
Outdated
rmw_implementation STREQUAL "rmw_fastrtps_cpp" OR
rmw_implementation STREQUAL "rmw_fastrtps_dynamic_cpp"
)
Expand Down