Use matching validity dates for cert and permissions#205
Merged
mikaelarguedas merged 3 commits intoros2:masterfrom May 4, 2020
Merged
Use matching validity dates for cert and permissions#205mikaelarguedas merged 3 commits intoros2:masterfrom
mikaelarguedas merged 3 commits intoros2:masterfrom
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 77.52% 77.72% +0.19%
==========================================
Files 16 16
Lines 574 579 +5
Branches 53 53
==========================================
+ Hits 445 450 +5
Misses 109 109
Partials 20 20
Continue to review full report at Codecov.
|
ruffsl
approved these changes
May 2, 2020
Member
Author
|
@ros2/security-reviewers heads-up I'm planning on merging this today, please consider submitting your reviews in the next couple hours. |
This was referenced May 6, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix for #186
not_valid_beforeandnot_valid_after