Skip to content

update basic tutorials for foxy#201

Merged
mikaelarguedas merged 2 commits intoros2:masterfrom
mikaelarguedas:update_docs
Apr 30, 2020
Merged

update basic tutorials for foxy#201
mikaelarguedas merged 2 commits intoros2:masterfrom
mikaelarguedas:update_docs

Conversation

@mikaelarguedas
Copy link
Member

Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   60.00%   60.00%           
=======================================
  Files          16       16           
  Lines         565      565           
  Branches       52       52           
=======================================
  Hits          339      339           
  Misses        212      212           
  Partials       14       14           
Flag Coverage Δ
#unittests 60.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3c42f...2d2ab6d. Read the comment docs.

ruffsl
ruffsl previously approved these changes Apr 24, 2020
SROS2_MacOS.md Outdated
```bash
ros2 security create_key demo_keys /talker
ros2 security create_key demo_keys /listener

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no white space needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 see 2d2ab6d

ivanpauno
ivanpauno previously approved these changes Apr 24, 2020
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There are some parts of the tutorial that still sound like each Node can have independent security settings, e.g.:

The previous demo used authentication and encryption, but not access control, which means that any authenticated node would be able to publish and subscribe to any data stream (aka topic). To increase the level of security in the system, you can define strict limits, known as access control, which restrict what each node is able to do. For example, one node would be able to publish to a particular topic, and another node might be able to subscribe to that topic. To do this, we will use the sample policy file provided in examples/sample_policy.xml.

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@mikaelarguedas mikaelarguedas dismissed stale reviews from ivanpauno and ruffsl via 2d2ab6d April 27, 2020 20:30
@mikaelarguedas
Copy link
Member Author

There are some parts of the tutorial that still sound like each Node can have independent security settings, e.g.:

@ivanpauno I'm not sure what the best wording for this would be, we could replace "node" with "process" but apart from that I'm not sure how to add correctness without adding complexity.
Did you have a wording suggestion in mind ?

@ivanpauno
Copy link
Member

@ivanpauno I'm not sure what the best wording for this would be, we could replace "node" with "process" but apart from that I'm not sure how to add correctness without adding complexity.
Did you have a wording suggestion in mind ?

Not much more than that, my idea was to replace node with process everywhere (or almost everywhere).

I think it can be done in a follow-up if you want, as this makes the tutorial work again.

@mikaelarguedas
Copy link
Member Author

I gave that an unsatisfactory try so I'll just merge this as is as suggested to make fix the tutorial and revisit the wording at a later date. thanks @ivanpauno for the feedback

@mikaelarguedas mikaelarguedas merged commit 7bb8a45 into ros2:master Apr 30, 2020
@mikaelarguedas mikaelarguedas deleted the update_docs branch April 30, 2020 21:51
@ivanpauno ivanpauno mentioned this pull request May 1, 2020
20 tasks
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants