Merged
Conversation
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
ruffsl
previously approved these changes
Apr 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 54.92% 55.15% +0.23%
==========================================
Files 15 16 +1
Lines 579 582 +3
Branches 52 52
==========================================
+ Hits 318 321 +3
Misses 247 247
Partials 14 14
Continue to review full report at Codecov.
|
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the reorganization of #188 by extracting the permission API into its own module.
Note that this introduces no behavioral changes, it's just moving code around.