Skip to content

Symlink CA certs instead of copy #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobperron merged 5 commits into from
Mar 3, 2020
Merged

Symlink CA certs instead of copy #176

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
425b670
Symlink CA certs instead of copy
ruffsl Feb 22, 2020
0013204
Restore local variables
ruffsl Feb 22, 2020
65aeffd
Fix linter
ruffsl Feb 22, 2020
39ab695
Add try case for existing symlinks
ruffsl Feb 24, 2020
bdcb66a
Update sros2/sros2/api/__init__.py
ruffsl Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions sros2/sros2/api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,13 +279,20 @@ def create_key(keystore_path, identity):
key_dir = os.path.join(keystore_path, relative_path)
os.makedirs(key_dir, exist_ok=True)

# copy the CA cert in there
keystore_ca_key_path = os.path.join(keystore_path, 'ca.key.pem')
keystore_ca_cert_path = os.path.join(keystore_path, 'ca.cert.pem')
dest_identity_ca_cert_path = os.path.join(key_dir, 'identity_ca.cert.pem')
dest_permissions_ca_cert_path = os.path.join(key_dir, 'permissions_ca.cert.pem')
shutil.copyfile(keystore_ca_cert_path, dest_identity_ca_cert_path)
shutil.copyfile(keystore_ca_cert_path, dest_permissions_ca_cert_path)

# symlink the CA cert in there
public_certs = ['identity_ca.cert.pem', 'permissions_ca.cert.pem']
for public_cert in public_certs:
dst = os.path.join(key_dir, public_cert)
relativepath = os.path.relpath(keystore_ca_cert_path, key_dir)
try:
os.symlink(src=relativepath, dst=dst)
except FileExistsError as e:
if not os.path.samefile(keystore_ca_cert_path, dst):
print('Existing symlink does not match!')
raise RuntimeError(str(e))

# copy the governance file in there
keystore_governance_path = os.path.join(keystore_path, 'governance.p7s')
Expand Down