fix certificate start date to work regardless of the timezone#148
Merged
jacobperron merged 1 commit intoros2:masterfrom Aug 7, 2019
Merged
fix certificate start date to work regardless of the timezone#148jacobperron merged 1 commit intoros2:masterfrom
jacobperron merged 1 commit intoros2:masterfrom
Conversation
Otherwise it fails with 'RTI_Security_CertHelper_verifyCert:X509_verify_cert returned 0 with error 9: certificate is not yet valid' Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
ruffsl
approved these changes
Aug 1, 2019
kyrofa
approved these changes
Aug 1, 2019
Member
kyrofa
left a comment
There was a problem hiding this comment.
Yeah seems sensible, thanks @mikaelarguedas!
Member
Author
|
@jacobperron or @mjcarroll gentle 🛎️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the machine generating the certificate has a local time ahead of UTC, the nodes fail to be created.
This PR switches to uses UTC time for the certificate start and end of validity times.
Error messages
Fast-RTPS:
Connext:
Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com