Make rviz1_to_rviz2.py accept configs with missing values #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <[email protected]>
|
CI (build:
|
ahcorde
approved these changes
Jan 26, 2023
|
@sloretz Do we need to backport this? |
delete-merged-branch
bot
deleted the
sloretz__more_lenient_rviz1_porting
branch
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Shane Loretz <[email protected]> (cherry picked from commit a9a4d9e) # Conflicts: # rviz2/scripts/rviz1_to_rviz2.py # rviz2/test/tools/rviz1_to_2_check.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of locusrobotics/fuse#309
There were a couple RViz configs in the fuse repository that could not be converted using the conversion script because they were missing some values. This PR includes those two RViz configs as test cases, and makes the conversion tool more leinent about missing options by adding defaults for them.