Skip to content

Use "%s" as format string literal in logging macros #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjwwood merged 1 commit into from
Dec 18, 2020
Merged

Use "%s" as format string literal in logging macros #633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rviz2/src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,16 @@ int main(int argc, char ** argv)
// install logging handlers to route logging through ROS's logging system
rviz_common::set_logging_handlers(
[logger](const std::string & msg, const std::string &, size_t) {
RCLCPP_DEBUG(logger, msg.c_str());
RCLCPP_DEBUG(logger, "%s", msg.c_str());
},
[logger](const std::string & msg, const std::string &, size_t) {
RCLCPP_INFO(logger, msg.c_str());
RCLCPP_INFO(logger, "%s", msg.c_str());
},
[logger](const std::string & msg, const std::string &, size_t) {
RCLCPP_WARN(logger, msg.c_str());
RCLCPP_WARN(logger, "%s", msg.c_str());
},
[logger](const std::string & msg, const std::string &, size_t) {
RCLCPP_ERROR(logger, msg.c_str());
RCLCPP_ERROR(logger, "%s", msg.c_str());
}
);

Expand Down