Skip to content

Avoid hiding base class getRenderOperation in PointCloudRenderable#586

Merged
ivanpauno merged 1 commit intoros2from
ivanpauno/avoid-hidding-getRenderOperation
Jul 27, 2020
Merged

Avoid hiding base class getRenderOperation in PointCloudRenderable#586
ivanpauno merged 1 commit intoros2from
ivanpauno/avoid-hidding-getRenderOperation

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

This avoid hiding the base class method instead of ignoring the warning.

Follow up of #553.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added enhancement New feature or request in review Waiting for review (Kanban column) labels Jul 24, 2020
@ivanpauno ivanpauno requested a review from wjwwood July 24, 2020 19:25
@ivanpauno ivanpauno self-assigned this Jul 24, 2020
Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with CI

@ivanpauno
Copy link
Copy Markdown
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 78a59cf into ros2 Jul 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/avoid-hidding-getRenderOperation branch July 27, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants