Closed
Conversation
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
Author
|
CI |
ivanpauno
approved these changes
Aug 27, 2020
Member
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM with fresher CI and the macOS/Windows failures resolved (are they related?)
sloretz
approved these changes
Nov 5, 2020
Contributor
sloretz
left a comment
sloretz
left a comment
There was a problem hiding this comment.
@claireyywang mind re-running CI?
Contributor
|
@claireyywang ping |
Author
|
@hidmic sorry about the delay. I'll take a look soon. |
Contributor
|
Closing this as unnecessary since we mostly don't use cppcheck anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of the effort to pin cppcheck 2.0, ros2/ros2#942
Signed-off-by: claireyywang 22240514+claireyywang@users.noreply.github.com