Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warnings - strict-prototypes #155

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 17, 2024

There are new warnings on CI related with this compiler option strict-prototypes

https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/1860/gcc/new/

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 23, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 2cc4e4e into rolling Apr 24, 2024
3 checks passed
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 24, 2024

https://github.com/Mergifyio backport jazzy

Copy link

mergify bot commented Apr 24, 2024

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 24, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 2cc4e4e)
ahcorde added a commit that referenced this pull request Apr 24, 2024
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 2cc4e4e)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants