Skip to content

Fast-forward Foxy #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobperron merged 2 commits into from
Aug 18, 2020
Merged

Fast-forward Foxy #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45e1bf
Add pytest.ini so tests succeed locally. (#116)
clalancette Jun 30, 2020
cd55302
fix too early decref of WString when converting from Python to C (#117)
dirk-thomas Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rosidl_generator_py/pytest.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[pytest]
junit_family=xunit2
6 changes: 4 additions & 2 deletions rosidl_generator_py/resource/_msg_support.c.em
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,14 +344,15 @@ nested_type = '__'.join(type_.namespaced_name())
char * buffer;
Py_ssize_t length;
int rc = PyBytes_AsStringAndSize(encoded_item, &buffer, &length);
Py_DECREF(encoded_item);
if (rc) {
Py_DECREF(encoded_item);
Py_DECREF(seq_field);
Py_DECREF(field);
return false;
}
// use offset of 2 to skip BOM mark
bool succeeded = rosidl_runtime_c__U16String__assignn_from_char(&dest[i], buffer + 2, length - 2);
Py_DECREF(encoded_item);
if (!succeeded) {
Py_DECREF(seq_field);
Py_DECREF(field);
Expand Down Expand Up @@ -429,14 +430,15 @@ nested_type = '__'.join(type_.namespaced_name())
char * buffer;
Py_ssize_t length;
int rc = PyBytes_AsStringAndSize(encoded_field, &buffer, &length);
Py_DECREF(encoded_field);
if (rc) {
Py_DECREF(encoded_field);
Py_DECREF(field);
return false;
}
// use offset of 2 to skip BOM mark
{
bool succeeded = rosidl_runtime_c__U16String__assignn_from_char(&ros_message->@(member.name), buffer + 2, length - 2);
Py_DECREF(encoded_field);
if (!succeeded) {
Py_DECREF(field);
return false;
Expand Down