Skip to content

add to_yaml() function for C++ messages (take 2)#527

Merged
dirk-thomas merged 5 commits intomasterfrom
dirk-thomas/cpp_to_yaml2
Sep 11, 2020
Merged

add to_yaml() function for C++ messages (take 2)#527
dirk-thomas merged 5 commits intomasterfrom
dirk-thomas/cpp_to_yaml2

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

Redo of #523.

CI builds testing rosidl_generator_cpp but building all packages to ensure the generated code works for all messages:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@dirk-thomas dirk-thomas added the enhancement New feature or request label Sep 11, 2020
@dirk-thomas dirk-thomas self-assigned this Sep 11, 2020
This reverts commit 2330a8e.

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/cpp_to_yaml2 branch from eefc71c to 4015c37 Compare September 11, 2020 19:25
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞

@dirk-thomas dirk-thomas merged commit 99e05f8 into master Sep 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/cpp_to_yaml2 branch September 11, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants