Closed
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Contributor
Author
Contributor
|
Hey @sloretz I tried that locally and had a few more issues. Could have been some leftover items in my local environment, so we will see. If this passes happy to close out my revert, but if this fails could we proceed with the revert approach? Thanks for the quick response. |
Contributor
Author
Yup. If this fails lets revert. |
Closed
dirk-thomas
approved these changes
Sep 10, 2020
Contributor
Author
|
My Local build failed too (clean build up to tf2_ros). Let's go ahead with the revert. Build failure output in test_msgsDetails |
Contributor
|
@sloretz FWIW that's what I saw as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dabonnie FYI this might be an alternative to reverting #523
Alternative to #525