Conversation
Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
|
CI |
|
CI again |
ivanpauno
left a comment
ivanpauno
left a comment
There was a problem hiding this comment.
LGTM with fresher CI!
(I'm not quite sure if those Windows/macOS failures were related or not)
| find_package(rosidl_typesupport_interface REQUIRED) | ||
| # Give cppcheck hints about macro definitions coming from outside this package | ||
| get_target_property( | ||
| ament_cmake_cppcheck_ADDITIONAL_INCLUDE_DIRS rosidl_typesupport_interface::rosidl_typesupport_interface INTERFACE_INCLUDE_DIRECTORIES) |
There was a problem hiding this comment.
note to self, ament_cmake_cppcheck_ADDITIONAL_INCLUDE_DIRS comes from here: https://github.com/ament/ament_lint/blob/8bf194aa1ac282db5483dd0d3fefff8f325b0db8/ament_cmake_cppcheck/cmake/ament_cppcheck.cmake#L18-L20
|
@claireyywang @nuclearsandwich does the CI branch https://github.com/ros2/ci/tree/revert-472-nuclearsandwich/pin-cppcheck need to be brought up to date before rerunning CI for this PR? |
Things have been pretty stable but I'll check and rebase if necessary then report back. |
|
We haven't moved on this in close to 2 years now, and in the meantime we've more-or-less deprecated cppcheck. So I'm going to close this one out. |
5 participants
part of the effort to pin cppcheck 2.0, ros2/ros2#942
Signed-off-by: claireyywang 22240514+claireyywang@users.noreply.github.com