Skip to content

[test] reindexer core OSX fix#691

Closed
emersonknapp wants to merge 48 commits intomasterfrom
emersonknapp/reindexer_core
Closed

[test] reindexer core OSX fix#691
emersonknapp wants to merge 48 commits intomasterfrom
emersonknapp/reindexer_core

Conversation

@emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented Mar 25, 2021 •
edited
Loading

temporary test fork of #641 to try fixing the OSX tests

Jacob Hassold added 30 commits March 23, 2021 13:52
@emersonknapp
Copy over relevant work to start
afd835a 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Remove sequential_reindexer
b6c02a7 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Switching to reader for metadata queries.
9a87171 
Currently does not build.
Has a template error with making a unique
pointer around a StorageFactoryInterface
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Properly construct reader.
1e3db0d 
Project builds again.
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Add test bags for unit testing
35cc9b6 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Starting framework for unit test.
fdf57ce 
Trying to figure out why we can't open multiple bags in a row...
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Ignore temp database files
134127a 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Debugging reindexing not reading multiple files
42a3f00 
and writing out the metadata file
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Fix metadata writer
03fb790 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Begin moving metadata target files over
361237a 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Add other two target files
719e791 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
First working version of unit tests
ce009af 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Convert to rcutils directory iterator
e305fc4 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Remove debug code
b9eac0f 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Linting fix
4eb96d2 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Clean comments, switch to exceptions
e8b4389 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Re-add Mutex
6ceb61e 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Remove nested namespace
d1005e0 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Remove converter, commenting changes
d47a604 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Use map in creating topic metadata section
f39095d 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Remove unneeded database files
1bd59f5 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Trim unneeded functions and members
5445b5a 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Re-add mutex, take 2
1c0c0f5 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Missed a rename and remove
fc1111c 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Re add missing functions
9d0483c 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Documentation changes
ee30918 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Improve error messages, and put them in proper level
fe638f8 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Remove dead function
6881ad6 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Convert regex pattern to member variable
6fe4984 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Extend documentation
01fd6e9 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
Jacob Hassold and others added 18 commits March 23, 2021 13:53
@emersonknapp
Properly capture bag size
bb6b221 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Allow rosbag2 storage to return expected file extension
ef0ae0a 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
[WIP] [DOES NOT COMPILE]
5816137 
Trying to figure out a clean way to access new function for getting
the expected storage extension
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Revert storage extension attempt.
29f99c6 
Use Regex to determine loadable files.
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Remove unused function from header
d609f30 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Remove unneeded comments
c6df120 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Fixed comment typo
a1b1175 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Remove API for get_storage_extension
4157197 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Comment improvements
133e779 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Use default destructor
1ce69f5 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Bring documentation comments in-line with
19530f8 
rest of project
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Try to fix undeclared identifier in Windows build
cd193d7 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Fix error being logged to debug
8c13eba 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Move testing code to its new home in rosbag2_tests
6a73558 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Revert stream logging change
b2d0fd4 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Make sure variable is initialized before displaying
8e69f23 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Add in possibly-missing dependency
ee876cd 
Distro A, OPSEC #4584

Signed-off-by: Jacob Hassold <jhassold@dcscorp.com>
@emersonknapp
Fix test by creating a new bagfile - it seems like it was corrupted i…
fb8c4a5 
…n some way

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Mar 25, 2021

Gist: https://gist.githubusercontent.com/emersonknapp/d90bd3df28065c9574e44edb913d389f/raw/2cb09d6a8b7d1db89abe4e3a449df2d5dbc406f2/ros2.repos
BUILD args: --packages-up-to rosbag2_tests
TEST args: --packages-select rosbag2_tests
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/7979

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp emersonknapp mentioned this pull request Mar 25, 2021
Merged
@emersonknapp emersonknapp deleted the emersonknapp/reindexer_core branch March 26, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@emersonknapp