[Foxy backport] Validate QoS profile values are not negative. (#483)#490
Merged
Karsten1987 merged 1 commit intofoxyfrom Aug 5, 2020
Merged
[Foxy backport] Validate QoS profile values are not negative. (#483)#490Karsten1987 merged 1 commit intofoxyfrom
Karsten1987 merged 1 commit intofoxyfrom
Conversation
* add negative check to init py Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * add unit test Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify unit test Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * revert test_play Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * typo string to int Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * add history value to unit tests Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * add validation to duration keys Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify duration validation Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * fix syntax Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify duration validation Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * fix syntax Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify comparison Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * fix syntax Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify style Signed-off-by: Jesse Ikawa <jikawa@amazon.com> * modify style Signed-off-by: Jesse Ikawa <jikawa@amazon.com> Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
dabonnie
force-pushed
the
dabonnie/backport-483
branch
from
35a59b1 to
7a32187
Compare
Contributor
Author
|
Collaborator
|
@clalancette let me know that for backport PRs, the |
Collaborator
|
With ros distro target "foxy":
|
Collaborator
|
Once more with a custom CI branch:
|
Karsten1987
approved these changes
Aug 5, 2020
Collaborator
Karsten1987
left a comment
Karsten1987
left a comment
There was a problem hiding this comment.
the PR job failure is clearly unrelated.
Collaborator
|
@j-rivero it looks like something went wrong in this PR here: ros2/ci#471 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #483
Signed-off-by: Jesse Ikawa jikawa@amazon.com