Add user provided split size to error#430
Merged
piraka9011 merged 4 commits intoros2:masterfrom Jun 3, 2020
Merged
Conversation
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Contributor
Author
|
zmichaels11
approved these changes
Jun 3, 2020
Contributor
zmichaels11
left a comment
zmichaels11
left a comment
There was a problem hiding this comment.
LGTM
Do you need a unit test for SequentialCompressionWriter to verify it throws when bad input is passed?
Contributor
Author
|
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Contributor
Author
|
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
zmichaels11
approved these changes
Jun 3, 2020
zmichaels11
approved these changes
Jun 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::runtime_errorin tests.Signed-off-by: Anas Abou Allaban allabana@amazon.com