find rosbag2_cpp (tinyxml2) before rcl#423
Merged
Karsten1987 merged 1 commit intomasterfrom Jun 1, 2020
Merged
Conversation
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Collaborator
Author
|
Regular CI (--packages-up-to rosbag2_transport, packages-select rosbag2_transport):
Windows packaging job: |
jacobperron
approved these changes
May 30, 2020
clalancette
approved these changes
Jun 1, 2020
Member
|
@Karsten1987 This could / should be reverted with ros2/tinyxml2_vendor#10 merged. |
Karsten1987
added a commit
that referenced
this pull request
Jun 11, 2020
This reverts commit 48fd15e.
Karsten1987
added a commit
that referenced
this pull request
Jun 11, 2020
Karsten1987
added a commit
that referenced
this pull request
Jun 11, 2020
Karsten1987
added a commit
that referenced
this pull request
Jun 17, 2020
Karsten1987
added a commit
that referenced
this pull request
Jun 17, 2020
adamdbrw
pushed a commit
to RobotecAI/rosbag2
that referenced
this pull request
Aug 4, 2020
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects to ros2/ros2#927 and should hopefully unblock the failing windows ci packaging jobs.
Note that this job only fails when
ENABLE_TESTING=OFFfor rosbag2_transport./cc @jacobperron