[compression] Close storage before compression#284
Merged
zmichaels11 merged 2 commits intoros2:masterfrom Feb 7, 2020
Merged
Conversation
zmichaels11
approved these changes
Feb 4, 2020
rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp
Outdated
Show resolved
Hide resolved
emersonknapp
approved these changes
Feb 4, 2020
thomas-moulard
suggested changes
Feb 4, 2020
Contributor
thomas-moulard
left a comment
thomas-moulard
left a comment
There was a problem hiding this comment.
Let's make sure this is the right logical approach as we discussed offline.
Contributor
Author
|
Investigating a better approach to closing the bag file since this may result in an extra bag file generated if there are no more new messages. |
piraka9011
force-pushed
the
clean-compression
branch
2 times, most recently
from
25cbdc5 to
d56476f
Compare
Signed-off-by: Anas Abou Allaban <allabana@amazon.com> Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
force-pushed
the
clean-compression
branch
from
d56476f to
3d57d71
Compare
zmichaels11
changed the title
zmichaels11
force-pushed
the
clean-compression
branch
from
3d57d71 to
b546ee2
Compare
Contributor
|
I've verified in #263 that this approach does fix a bug visible in Windows.
|
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
force-pushed
the
clean-compression
branch
from
b546ee2 to
d834a85
Compare
Contributor
|
@ros2/aws-oncall - please run this CI job |
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Note
Signed-off-by: Anas Abou Allaban allabana@amazon.com