[compression] Add SequentialCompressionWriter#260
Merged
zmichaels11 merged 4 commits intoros2:masterfrom Jan 22, 2020
Merged
Conversation
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
zmichaels11
force-pushed
the
sc-writer
branch
from
1e2eaec to
fa99bec
Compare
zmichaels11
changed the title
zmichaels11
force-pushed
the
sc-writer
branch
from
01aebd6 to
b8ee61c
Compare
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
force-pushed
the
sc-writer
branch
from
b8ee61c to
506dc78
Compare
zmichaels11
requested review from
Karsten1987,
dabonnie,
emersonknapp and
thomas-moulard
Karsten1987
reviewed
Jan 21, 2020
Collaborator
Karsten1987
left a comment
Karsten1987
left a comment
There was a problem hiding this comment.
I guess it's the same comment I made for the reader implementation of this, but there's quite some code duplication around which I believe should be addressed by inheritance.
Otherwise, I guess that looks good so far if all tests pass.
rosbag2_compression/include/rosbag2_compression/sequential_compression_writer.hpp
Show resolved
Hide resolved
rosbag2_compression/include/rosbag2_compression/sequential_compression_writer.hpp
Show resolved
Hide resolved
rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp
Show resolved
Hide resolved
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
zmichaels11
force-pushed
the
sc-writer
branch
from
7a6d65e to
16ad8cb
Compare
Contributor
Author
|
@ros2/aws-oncall - please run this CI job |
Contributor
|
Signed-off-by: Zachary Michaels <zmichaels11@gmail.com>
Contributor
Author
|
Run again with change for Windows:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a SequentialCompressionWriter that uses ZStandard compression to write bagfiles.
Depends on PR: #258