Closed
Conversation
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
fujitatomoya
reviewed
Aug 9, 2024
Contributor
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@sloretz @MichaelOrlov @christophebedard
in lint.yml there are some workflows use old image rostooling/setup-ros-docker:ubuntu-focal-ros-rolling-ros-base-latest, should we also change it into rostooling/setup-ros-docker:ubuntu-noble-ros-rolling-ros-base-latest?
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Contributor
|
@sloretz #1709 includes this fix? i think @MichaelOrlov is trying to address workflow container images update too. |
Contributor
Author
It does! I'll close this in favor of #1709 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using these docker images:
Context: ros2/rclpy#1249 (comment)