Add recommendation on example source PR #4253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Other ROS devs could use an example directly in the docs for what is a source PR * Fix incorrect grammar Signed-off-by: Ryan Friedman <[email protected]>
clalancette
requested changes
Apr 3, 2024
Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Ryan <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
clalancette
added
the
backport-all
clalancette
approved these changes
Apr 3, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Thanks for iterating, this looks good.
mergify bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Add recommendation on example source PR * Other ROS devs could use an example directly in the docs for what is a source PR * Fix incorrect grammar Signed-off-by: Ryan Friedman <[email protected]> Signed-off-by: Ryan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 9fe4c95)
mergify bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Add recommendation on example source PR * Other ROS devs could use an example directly in the docs for what is a source PR * Fix incorrect grammar Signed-off-by: Ryan Friedman <[email protected]> Signed-off-by: Ryan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 9fe4c95)
clalancette
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Add recommendation on example source PR * Other ROS devs could use an example directly in the docs for what is a source PR * Fix incorrect grammar Signed-off-by: Ryan Friedman <[email protected]> Signed-off-by: Ryan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 9fe4c95) Co-authored-by: Ryan <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Add recommendation on example source PR * Other ROS devs could use an example directly in the docs for what is a source PR * Fix incorrect grammar Signed-off-by: Ryan Friedman <[email protected]> Signed-off-by: Ryan <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit 9fe4c95) Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It is not clear what a
sourcePR to rosdistro is. I was told to do this, but not how. Now, we directly link an example.I also fixed some grammar.
Reference
Others had the same question here:
ros2-gbp/ros2-gbp-github-org#393 (comment)