Merged
Conversation
20 tasks
Member
Author
|
CI at ros2/sros2#198 (comment) |
ivanpauno
approved these changes
Apr 10, 2020
Member
|
You can ignore the failing checks, as they don't take in account simultaneous in other repos. |
ruffsl
reviewed
Apr 10, 2020
ruffsl
approved these changes
Apr 10, 2020
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
force-pushed
the
enclaves
branch
from
370c24c to
a13bf9d
Compare
rotu
requested changes
Apr 11, 2020
Collaborator
rotu
left a comment
rotu
left a comment
There was a problem hiding this comment.
Approved pending ros2/rmw#211
The dashing check can be ignored - it shouldn't be running on this commit, which doesn't target dashing. The other failures look like they'll pass once ros2/rmw#211 is merged.
ivanpauno
approved these changes
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikael Arguedas mikael.arguedas@gmail.com