Move RCUTILS_PATH_DELIMITER to header#294
Closed
christophebedard wants to merge 1 commit intoros2:masterfrom
Closed
Move RCUTILS_PATH_DELIMITER to header#294christophebedard wants to merge 1 commit intoros2:masterfrom
christophebedard wants to merge 1 commit intoros2:masterfrom
Conversation
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
fujitatomoya
approved these changes
Sep 30, 2020
Contributor
|
@christophebedard Is this still required? Sorry, its unclear to me from the context of ros2/rcl_logging#53 |
Member
Author
I ended up not using it for ros2/rcl_logging#53, but maybe it could still be useful? I'd leave that up to you. |
Contributor
If we don't need it right now, I'm going to say we shouldn't make the change. It is simple enough, so we can always do it in the future if need be. So I'm going to close this out for now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way it can be used by other packages.