Skip to content

Add PythonAllocator#746

Merged
sloretz merged 2 commits intomasterfrom
python_allocator
Apr 2, 2021
Merged

Add PythonAllocator#746
sloretz merged 2 commits intomasterfrom
python_allocator

Conversation

@sloretz
Copy link
Copy Markdown
Contributor

@sloretz sloretz commented Mar 31, 2021

Follow up from #739 (comment)

This implements a C++ allocator that uses PyMem_Malloc() and PyMem_Free(), and uses it to replace new/delete in the Client class.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz requested a review from hidmic March 31, 2021 18:14
@sloretz sloretz self-assigned this Mar 31, 2021
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Mar 31, 2021

CI Windows debug (build: --packages-up-to rlcpy test: --packages-select rclpy) to check if there are any surprises there first: Build Status

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 1, 2021

Typo in build args, WIndows debug again (build: --packages-up-to rclpy test: --packages-select rclpy)
Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 1, 2021

CI (build: --packages-above-and-dependencies rclpy test: --packages-above rclpy)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz
Copy link
Copy Markdown
Contributor Author

sloretz commented Apr 2, 2021

CI LGTM, test failures and warnings are also in the nightly.

@sloretz sloretz merged commit 72ae325 into master Apr 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the python_allocator branch April 2, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants