Skip to content

Add method to get the current logging directory#657

Merged
ivanpauno merged 3 commits intomasterfrom
ivanpauno/get-logging-dir
Jan 11, 2021
Merged

Add method to get the current logging directory#657
ivanpauno merged 3 commits intomasterfrom
ivanpauno/get-logging-dir

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

Similar to ros2/rclcpp#1509.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Jan 8, 2021
@ivanpauno ivanpauno requested a review from jacobperron January 8, 2021 18:39
@ivanpauno ivanpauno self-assigned this Jan 8, 2021
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. LGTM

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Copy Markdown
Member Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivanpauno ivanpauno merged commit 54d3c34 into master Jan 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/get-logging-dir branch January 11, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants