Add method in Node to resolve a topic or service name#636
Merged
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Member
Author
|
@ros-pull-request-builder retest this please |
Merged
jacobperron
approved these changes
Oct 29, 2020
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
One comment; take it or leave it.
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Member
Author
|
jacobperron
reviewed
Oct 29, 2020
Member
Author
|
I'm not sure why mac failed before, there shouldn't be anything platform dependent here:
|
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Member
Author
|
jacobperron
reviewed
Oct 30, 2020
Member
Author
|
🤞
|
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This reverts commit 09d56e4. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This reverts commit 76757f5. Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
force-pushed
the
ivanpauno/resolve-topic-name
branch
from
52ffb82 to
93b4309
Compare
Member
Author
|
Force pushed to fix missing DCO signing. |
jacobperron
approved these changes
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bindings for ros2/rcl#835.
Equivalent to ros2/rclcpp#1410.
Will be useful in #635.