Skip to content

Call init and shutdown thread safely#508

Merged
ivanpauno merged 3 commits intomasterfrom
ivanpauno/call-init-and-shutdown-thread-safely
Feb 14, 2020
Merged

Call init and shutdown thread safely#508
ivanpauno merged 3 commits intomasterfrom
ivanpauno/call-init-and-shutdown-thread-safely

Conversation

@ivanpauno
Copy link
Copy Markdown
Member

The rcl functions aren't thread safe.
The upper layer has to lock.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added bug Something isn't working in review Waiting for review (Kanban column) labels Feb 12, 2020
@ivanpauno ivanpauno self-assigned this Feb 12, 2020
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, did this show up as errors somewhere?

Also, consider adding this to the Dashing and Eloquent patch release project boards for backport.

@ivanpauno
Copy link
Copy Markdown
Member Author

Out of curiosity, did this show up as errors somewhere?

No, I realized about the problem in another discussion.
It's pretty hard to hit the problem, as shutdown should be called asynchronously while init is still running, which is an strange use-case.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Copy link
Copy Markdown
Member Author

  • Linux Build Status

@ivanpauno ivanpauno merged commit 6d009fb into master Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/call-init-and-shutdown-thread-safely branch February 14, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants