rclpy_take_response checks sequence number#171
Merged
Conversation
rclpy/rclpy/client.py
Outdated
| rclpy.utilities.shutdown() | ||
| return | ||
| response = _rclpy.rclpy_take_response( | ||
| seq_and_response = _rclpy.rclpy_take_response( |
Member
There was a problem hiding this comment.
Could we use something lilke [seq, response] = _rclpy.rclpy_take_response(... for readability?
Contributor
Author
There was a problem hiding this comment.
Sure. It just means making rclpy_take_response return (None, None) on when there is nothing to take instead of None.
Fixes a bug where rclpy_take_response was ignoring the sequence number returned by rcl_take_response in the struct rmw_request_id_t.
sloretz
force-pushed
the
rclpy_take_response_get_sequence
branch
from
76a3d07 to
e260ce6
Compare
mikaelarguedas
approved these changes
Jan 24, 2018
Member
mikaelarguedas
left a comment
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm thanks @sloretz for iterating
| PyTuple_SET_ITEM(pytuple, 1, pytaken_response); | ||
| return pytuple; | ||
| } | ||
| Py_INCREF(Py_None); |
Member
There was a problem hiding this comment.
I was surprised that Py_None needed to be incref'ed but apparently that's necessary 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where rclpy_take_response ignores the sequence number in a struct populated by rcl_take_response. This becomes important once the client supports multiple outstanding requests (#170).
connects to ros2/rcl#205
CI (with e260ce6)