Skip to content

keep consistency when destroying node raises an exception#149

Merged
dirk-thomas merged 1 commit intomasterfrom
destroy_node_consistency
Nov 17, 2017
Merged

keep consistency when destroying node raises an exception#149
dirk-thomas merged 1 commit intomasterfrom
destroy_node_consistency

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

Fixes the bad behavior described in ros2/ros2cli#62 but not the actual case of the exception.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Nov 17, 2017
@dirk-thomas dirk-thomas self-assigned this Nov 17, 2017
@dirk-thomas
Copy link
Copy Markdown
Member Author

@sloretz FYI since you modified the logic in #129 from "destroying and removing elements one by one" to "destroy all elements and empty the list afterwards".

@dirk-thomas dirk-thomas merged commit a2390ba into master Nov 17, 2017
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Nov 17, 2017
@dhood dhood deleted the destroy_node_consistency branch November 18, 2017 00:40
@dirk-thomas dirk-thomas restored the destroy_node_consistency branch December 3, 2017 16:43
@dhood dhood deleted the destroy_node_consistency branch July 18, 2018 02:03
YuanYuYuan pushed a commit to YuanYuYuan/rclpy that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants