Rclpy named capsules fixups#133
Merged
sloretz merged 2 commits intorclpy_named_capsulesfrom Oct 25, 2017
Merged
Conversation
mikaelarguedas
added
in progress
Contributor
|
It all looks good to me. Thanks for the doc fixes. In the future feel free to push to the branch directly. Just send a heads up so I don't accidentally overwrite them if I'm about to rebase onto master and force push. |
YuanYuYuan
pushed a commit
to YuanYuYuan/rclpy
that referenced
this pull request
Nov 12, 2025
Fix handling of ROS1 string constants, add test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sloretz I made a few fixups in the modified docblocks of #129 but didnt want to push directly on your branch. Feel free to cherry pick/apply what you think makes sense.