[Foxy] Allow configuring logging directory through environment variables#69
Conversation
* Add in a new rcl_logging_interface package. This has just the header files that the implementations need to provide, and that the callers can call. Also port log4cxx, noop, and spdlog backends to use this new interface. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Signed-off-by: tgreier <tgreier@moog.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: tgreier <tgreier@moog.com>
* Used current_path function from rcpputils Signed-off-by: ahcorde <ahcorde@gmail.com> * Removed fs namespace Signed-off-by: ahcorde <ahcorde@gmail.com> Signed-off-by: tgreier <tgreier@moog.com>
Signed-off-by: Alejandro Hernández Cordero <alejandro@openrobotics.org> Signed-off-by: tgreier <tgreier@moog.com>
|
This looks like a large change. It would be better to incrementally open up separate backports for each PR referenced. Also, we should make sure that anything we backport does not break things for existing users. For example, we can't remove public headers, since we'll break any downstream code currently including them. It might be possible to workaround this issue by including the equivalent header from Correct me if I'm wrong, but at a glance, it looks like it should be possible to backport #53 without the other three referenced PRs. It's not as simple as cherry-picking the change, but presumably we could add equivalent API to the existing logging packages in Foxy. |
|
Ok, I can kill this PR and take the approach of adding the functionality to Foxy without deleting any existing public headers (no cherry-picking). |
Sounds good. I'll go ahead and close this one then. |
Backport to Foxy the following PRs: