Use rcutils_expand_user() in rcl_logging_get_logging_directory()#59
Merged
clalancette merged 1 commit intoros2:masterfrom Oct 20, 2020
Merged
Conversation
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Member
Author
|
I'm guessing a new release of |
Contributor
Agreed, I'll go ahead and do that. |
Contributor
|
New release of rcutils is done, lets see if the PR build succeeds now. |
Contributor
|
@ros-pull-request-builder retest this please |
clalancette
approved these changes
Oct 19, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me now that PR jobs are passing. I'll also do a CI run on it.
Contributor
|
CI:
|
Contributor
|
The 4 failures on Windows are flaky right now. So I'm going to go ahead and merge this, thanks for the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #53, now that
rcutils_expand_userhas been added (ros2/rcutils#298).