Merged
Conversation
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
audrow
changed the title
clalancette
reviewed
Sep 29, 2020
Signed-off-by: Audrow Nash <audrow.nash@gmail.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
approved these changes
Sep 29, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good with green CI.
Member
Author
|
Signed-off-by: Audrow Nash <audrow.nash@gmail.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com>
Member
Author
|
Running different gtest versions to see if we can fix the warnings:
|
Member
Author
|
New CI run, after gtest has been updated to v1.10.0:
|
delete-merged-branch
bot
deleted the
audrow/add-warnings-rcl_logging_spdlog
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
-Wformat=2,-Wconversion,-Woverloaded-virtual,-Wshadow,-Wnon-virtual-dtor,-Wold-style-cast, and-Wcast-qualinrcl_logging_spdlog. No source code was modified to enable these warnings.Relies on
googletestbeing v1.10.0 (ament/googletest#8).