Skip to content

Add fault injection unittest to increase coverage #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brawner merged 4 commits into from
Aug 26, 2020
Merged

Add fault injection unittest to increase coverage #49

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1dcf349
Add fault injection unittest to increase coverage
brawner Jul 1, 2020
49ce56f
Update with recent rcutils changes
brawner Jul 28, 2020
df7e804
target definitions
brawner Aug 7, 2020
772f235
PR Fixup
brawner Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rcl_logging_spdlog/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ if(BUILD_TESTING)
ament_add_gtest(test_logging_interface test/test_logging_interface.cpp)
if(TARGET test_logging_interface)
target_link_libraries(test_logging_interface ${PROJECT_NAME})
target_compile_definitions(test_logging_interface PUBLIC RCUTILS_ENABLE_FAULT_INJECTION)
ament_target_dependencies(test_logging_interface rcpputils)
endif()
endif()
Expand Down
14 changes: 14 additions & 0 deletions rcl_logging_spdlog/test/test_logging_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include <rcutils/allocator.h>
#include <rcutils/env.h>
#include <rcutils/error_handling.h>
#include <rcutils/testing/fault_injection.h>
#include <rcutils/logging.h>
Comment thread
brawner marked this conversation as resolved.
Outdated

#include <limits.h>
Expand Down Expand Up @@ -162,3 +163,16 @@ TEST_F(LoggingTest, full_cycle)
expected_log.str(),
actual_log.str()) << "Unexpected log contents in " << log_file_path;
}

TEST_F(LoggingTest, init_fini_maybe_fail_test)
{
RCUTILS_FAULT_INJECTION_TEST(
{
if (RCL_LOGGING_RET_OK == rcl_logging_external_initialize(nullptr, allocator)) {
EXPECT_EQ(RCL_LOGGING_RET_OK, rcl_logging_external_shutdown());

@hidmic hidmic Aug 24, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brawner what if rcl_logging_external_shutdown() fails because of fault injection?

@brawner brawner Aug 25, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rcl_logging_external_shutdown() is currently very simple and doesn't call any external functions. The EXPECT_EQ will help notify people this test needs to be fixed should that function be modified.

https://github.com/ros2/rcl_logging/blob/master/rcl_logging_spdlog/src/rcl_logging_spdlog.cpp#L150-L154

} else {
EXPECT_TRUE(rcutils_error_is_set());
rcutils_reset_error();
}
});
}