Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bypass spdlog singleton registry #23

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Bypass spdlog singleton registry #23

merged 3 commits into from
Dec 10, 2019

Conversation

ivanpauno
Copy link
Member

@ivanpauno
Bypass spdlog singleton registry
e456035 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Copy link
Member Author

@clalancette @hidmic can you review this?

@ivanpauno ivanpauno mentioned this pull request Dec 6, 2019
Closed
hidmic
hidmic approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

clalancette
clalancette requested changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change for ownership semantics, and one request for a test. Otherwise, I like the direction.

rcl_logging_spdlog/src/rcl_logging_spdlog.cpp Outdated Show resolved Hide resolved
rcl_logging_spdlog/src/rcl_logging_spdlog.cpp Show resolved Hide resolved
@ivanpauno
Address coments
4d6bc4b 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno requested a review from clalancette December 9, 2019 13:20
@ivanpauno
Fix 'Include what you use' linter failure
73d8f35 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Copy link
Member Author

ivanpauno commented Dec 9, 2019 •
edited
Loading

One full CI:

  • Linux Build Status (unrelated failures)

The others up to rcl_logging_spdlog:

  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit baeb143 into ros2:master Dec 10, 2019
@sloretz sloretz mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@hidmic hidmic hidmic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spdlog generates a SEGFAULT when a context is being destructed
3 participants
@ivanpauno @clalancette @hidmic