compare the return value to constants#665
compare the return value to constants#665iuhilnehc-ynos wants to merge 2 commits intoros2:masterfrom
Conversation
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
rcl/src/rcl/logging.c
Outdated
| if (logging_status != 0) { | ||
| status = RCL_RET_ERROR; | ||
| status = rcl_logging_external_set_logger_level(NULL, default_level); | ||
| if (RCL_RET_OK == status) { |
There was a problem hiding this comment.
This changes a logic, only when log level can be set, then register handler?
Previously registering handler anyway even if log level cannot be set.
There was a problem hiding this comment.
Yes. And I think this is the correct logic. Maybe I was wrong.
There was a problem hiding this comment.
@fujitatomoya
After consideration, I shouldn't update the original logic while refactoring the source code.
I will update it.
There was a problem hiding this comment.
I guess that original logic is meant to, I'd like to hear from others.
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
|
I'd actually like to hold off on a change like this. Over in ros2/rcl_logging#33 (comment) , we've been discussing refactoring this interface, and the types that We aren't working on it at the moment, but feel free to start working on that if you'd like. Otherwise, I will probably start taking a look at fixing this up after Foxy is released. |
Thanks for your explanation. I got it and close this PR right now.
Actually, I updated this function because of #664 ( I noticed there is a TODO inside rcl_logging_configure_with_output_handler). |
3 participants
Signed-off-by: Chen Lihui Lihui.Chen@sony.com