Add new rcutils_raw_steady_time_now method changes #1248
Conversation
Signed-off-by: Sai Kishor Kothakota <[email protected]>
saikishor
force-pushed
the
add/raw_steady_time/clock
branch
from
885e12a to
f753b0a
Compare
|
@saikishor thanks for working on this, 🔥 great work! i will review this and ros2/rclcpp#291 in this weekend. |
Thank you |
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm.
I believe this is compatible change since it adds the enum at the end and free functions. besides, enum is not used in the data structure. but i would like to double-check on this.
rcl/include/rcl/time.h
Outdated
| * RCL_RAW_STEADY_TIME reports a value from a monotonic clock that is not | ||
| * adjusted for time jumps, such as those caused by NTP synchronization. | ||
| * This clock is not suitable for measuring elapsed time, but can be used to | ||
| * measure time intervals without being affected by system time changes. |
There was a problem hiding this comment.
this is not always the case and dependent on platform. should we also mention like if the system platform supports CLOCK_MONOTONIC_RAW in the docstring?
There was a problem hiding this comment.
Sure, I can update it
Signed-off-by: Sai Kishor Kothakota <[email protected]>
|
Pulls: #1248
|
This reverts commit c80701e. Signed-off-by: Tomoya Fujita <[email protected]>
…1267) This reverts commit c80701e. Signed-off-by: Tomoya Fujita <[email protected]>
3 participants
Related to ros2/rcutils#507
@fujitatomoya FYI