Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous Nodes #1034

Open
danthony06 opened this issue Feb 22, 2023 · 6 comments
Open

Anonymous Nodes #1034

danthony06 opened this issue Feb 22, 2023 · 6 comments
Assignees

Comments

@danthony06
Copy link

Feature request

Feature description

Enable anonymous node names.

Implementation considerations

We frequently used anonymous nodes in ROS 1 when developing debugging and introspection tools. I see a lot of references to anonymous nodes throughout the core ROS2 libraries, and inside rcl/node_options.h, but it seems to have been disabled or abandoned. I also saw this comment mentioning that they're a desirable feature: #375 (comment). Is there any reason they have not been implemented in ROS 2?

I think ROS1 just used the wall timer to generate a unique ID. Will this approach work in ROS 2?

@fujitatomoya
Copy link
Collaborator

This node option was considered long time ago, but never implemented yet.

// bool anonymous_name;

I think that this node option is useful for user application.

@danthony06
Copy link
Author

I've started working on adding this, and have a partial implementation.

1 similar comment
@danthony06
Copy link
Author

I've started working on adding this, and have a partial implementation.

@methylDragon
Copy link
Contributor

methylDragon commented Mar 2, 2023

This would be great to have!

Note that any implementation of this should append the anonymisation suffix after any node name and node namespace remaps are done (as well as after parameters are loaded.) Because otherwise users wouldn't be able to set parameters, and the node_name:__node:=new_node_name remap signature wouldn't work.

Another useful bonus would be if a CLI argument could be used to configure this behavior too.


PS: I had some internal discussions with the ROS folks and it seems like node anonymisation is a desired feature but just not implemented yet. So please do go ahead with an implementation!

@methylDragon methylDragon self-assigned this Mar 2, 2023
@danthony06
Copy link
Author

danthony06 commented Mar 2, 2023 via email

@methylDragon
Copy link
Contributor

I think following ROS 1 would be okay, and it has the added benefit of giving that little bit more information that helps to order nodes (alphanumerically, I mean)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants