This repository was archived by the owner on Jul 1, 2021. It is now read-only.
check Poco version and if below 1.4.1p1 build from source#10
Merged
dirk-thomas merged 2 commits intomasterfrom Sep 29, 2017
Merged
check Poco version and if below 1.4.1p1 build from source#10dirk-thomas merged 2 commits intomasterfrom
dirk-thomas merged 2 commits intomasterfrom
Conversation
| NO_DEFAULT_PATH | ||
| ) | ||
| if(NOT Poco_VERSION_FILE) | ||
| message(STATUS "Found Poco version (< 1.4.0) is too old, building from source instead") |
Member
There was a problem hiding this comment.
Looks like this version file was added in 1.3.7, can you clarify how you picked "1.4.0" for the printed message?
Member
Author
There was a problem hiding this comment.
The CHANGELOG lists the addition in the "Release 1.4.0" section. That is where I got the version number from. Also I don't see any listing of a version 1.3.7 (neither in the changelog nor as a tag).
Member
There was a problem hiding this comment.
ok, I guess they had a branch for it but didnt ever released 1.3.7 and several commits on that branch say "preparing for 1.4.0". Sorry for the noise
mikaelarguedas
approved these changes
Sep 29, 2017
Member
mikaelarguedas
left a comment
mikaelarguedas
left a comment
There was a problem hiding this comment.
Nice! ran 100 times without failing 👍
Member
Author
|
Thanks for catching and fixing the style glitch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ros2/demos#177 why we need at least Poco version 1.4.1p1.
This patch falls back to build Poco from source if the installed version is too old which fixes ros2/demos#177:
(look for
Found Poco version 0x01030600 is too old, building from source insteadin the console output).Fixes #9