Add a / path join operator for PathJoinSubstitution (backport #868)#876
Closed
mergify[bot] wants to merge 1 commit intojazzyfrom
Closed
Add a / path join operator for PathJoinSubstitution (backport #868)#876mergify[bot] wants to merge 1 commit intojazzyfrom
/ path join operator for PathJoinSubstitution (backport #868)#876mergify[bot] wants to merge 1 commit intojazzyfrom
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com> (cherry picked from commit e716d1f) # Conflicts: # launch/launch/substitutions/path_join_substitution.py # launch/test/launch/substitutions/test_path_join_substitution.py
Author
|
Cherry-pick of e716d1f has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
ahcorde
requested changes
May 7, 2025
Contributor
ahcorde
left a comment
There was a problem hiding this comment.
@emersonknapp do you mind to take care of the conflicts?
Contributor
|
Replaced by #880 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes robograph-project/planning#18
Adds a
PathJoinSubstition(['stuff']) / 'otherpattern.Also adds a
PathSubstitutionsimple wrapper that allows for passing a single value like:PathSubstitution('path') / 'subdir' / PathJoinSubstitution(['some', 'things'])Make launch feel a little more natural, match the modern
pathlib.PathAPI which we should be encouraging more, I see a lot ofos.pathin user-facing examples.Part of ergonomics pass.
This is an automatic backport of pull request #868 done by [Mergify](https://mergify.com).