Skip to content

Add a / path join operator for PathJoinSubstitution (backport #868)#876

Closed
mergify[bot] wants to merge 1 commit intojazzyfrom
mergify/bp/jazzy/pr-868
Closed

Add a / path join operator for PathJoinSubstitution (backport #868)#876
mergify[bot] wants to merge 1 commit intojazzyfrom
mergify/bp/jazzy/pr-868

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented May 7, 2025

Closes robograph-project/planning#18

Adds a PathJoinSubstition(['stuff']) / 'other pattern.

Also adds a PathSubstitution simple wrapper that allows for passing a single value like: PathSubstitution('path') / 'subdir' / PathJoinSubstitution(['some', 'things'])

Make launch feel a little more natural, match the modern pathlib.Path API which we should be encouraging more, I see a lot of os.path in user-facing examples.

Part of ergonomics pass.


This is an automatic backport of pull request #868 done by [Mergify](https://mergify.com).

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit e716d1f)

# Conflicts:
#	launch/launch/substitutions/path_join_substitution.py
#	launch/test/launch/substitutions/test_path_join_substitution.py
@mergify mergify bot added the conflicts label May 7, 2025
@mergify
Copy link
Copy Markdown
Author

mergify bot commented May 7, 2025

Cherry-pick of e716d1f has failed:

On branch mergify/bp/jazzy/pr-868
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit e716d1f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   launch/launch/substitutions/__init__.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   launch/launch/substitutions/path_join_substitution.py
	both modified:   launch/test/launch/substitutions/test_path_join_substitution.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Copy Markdown
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emersonknapp do you mind to take care of the conflicts?

@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 15, 2025

Replaced by #880

@ahcorde ahcorde closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants