Skip to content

[backport humble] Add conditional substitution (#734)#870

Merged
christophebedard merged 1 commit intoros2:humblefrom
emersonknapp:backport-734-humble
May 29, 2025
Merged

[backport humble] Add conditional substitution (#734)#870
christophebedard merged 1 commit intoros2:humblefrom
emersonknapp:backport-734-humble

Conversation

@emersonknapp
Copy link
Copy Markdown
Contributor

@emersonknapp emersonknapp commented May 1, 2025 •
edited
Loading

Backport #734 to Humble

Depends on #871 (only for docblock example code, but I would rather maintain that than make edits)

@emersonknapp
Copy link
Copy Markdown
Contributor Author

emersonknapp commented May 2, 2025

Pulls: #870
Gist: https://gist.githubusercontent.com/emersonknapp/728101e82b81f5bc170147a420df7455/raw/d0c9e9c9e68397506fbafef3234a33c27121a3e1/ros2.repos
BUILD args: --packages-above-and-dependencies launch
TEST args: --packages-above launch
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15892

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard self-requested a review May 15, 2025 17:17
@emersonknapp emersonknapp moved this to In review in Robograph Planning May 16, 2025
@nlamprian @emersonknapp
[backport humble] Add conditional substitution (ros2#734)
c06bd88 
* Add conditional substitution

Closes: ros2#727

Signed-off-by: Nick Lamprianidis <info@nlamprian.me>
@emersonknapp emersonknapp force-pushed the backport-734-humble branch from 541af01 to c06bd88 Compare May 19, 2025 17:24
@emersonknapp
Copy link
Copy Markdown
Contributor Author

emersonknapp commented May 19, 2025 •
edited by christophebedard
Loading

Pulls: #870
Gist: https://gist.githubusercontent.com/emersonknapp/ac47b1855c22bd3e247434385c4f9d5a/raw/d0c9e9c9e68397506fbafef3234a33c27121a3e1/ros2.repos
BUILD args: --packages-above-and-dependencies launch
TEST args: --packages-above launch
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16043

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented May 19, 2025

The Windows job failed because of a 429 Too Many Requests with GitHub, so I re-triggered it.

@christophebedard christophebedard self-assigned this May 29, 2025
@christophebedard christophebedard merged commit ac1c270 into ros2:humble May 29, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Robograph Planning May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees

@christophebedard christophebedard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emersonknapp @christophebedard @nlamprian