Skip to content

Expose StringJoinSubstitution to frontend#857

Merged
christophebedard merged 15 commits intoros2:rollingfrom
baconbrot:stringjoinsubstitution_frontend
Oct 23, 2025
Merged

Expose StringJoinSubstitution to frontend#857
christophebedard merged 15 commits intoros2:rollingfrom
baconbrot:stringjoinsubstitution_frontend

Conversation

@baconbrot
Copy link
Copy Markdown
Contributor

@baconbrot baconbrot commented Apr 12, 2025

This PR exposes StringJoinSubstitution from #843 to the frontend, as suggested by @christophebedard in #843.

Usage

(i.e. with delimiter=. and string components=[https://$(var subdomain), ros, org]):

%YAML 1.2
---
launch:
  - arg:
      name: subdomain
      default: 'wiki'
  - log:
      message: "$(string-join . https://$(var subdomain) ros org)"

results in terminal output

[INFO] [launch.user]: https://wiki.ros.org

@baconbrot baconbrot marked this pull request as draft April 12, 2025 12:32
christophebedard
christophebedard reviewed Apr 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some minor comments, this looks good.

Would you mind adding tests for frontends, i.e., YAML and XML? See the tests I added to launch_xml and launch_yaml in #802. Also, it would be good to add XML and YAML examples to the Python class docstring.

@baconbrot baconbrot force-pushed the stringjoinsubstitution_frontend branch from bc7bb1e to 669c430 Compare April 27, 2025 18:12
@baconbrot baconbrot marked this pull request as ready for review April 27, 2025 18:30
christophebedard
christophebedard reviewed Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

Other than some minor suggestions, this looks great!

baconbrot added a commit to baconbrot/launch that referenced this pull request Oct 21, 2025
@baconbrot
Use ld.entities instead of describe_sub_entities as of ros2#857 (comm…
207ac0c 
…ent)

Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
baconbrot and others added 10 commits October 21, 2025 11:01
@baconbrot
Expose StringJoinSubstitution to frontend
97839d1 
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot
Fix type and flake error
67e708b 
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot
Wrap data in iter instead of normalizing here
35ceba5 
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot @christophebedard
Update launch/launch/substitutions/string_join_substitution.py
dd146aa 
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot
Set explicit dict type for frontend kwargs
d07a093 
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot
Add xml and yaml test
0334554 
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot
Add xml and yaml exmaple to docstring
3243a78 
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot
Remove trailing whitespace
09f2924 
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot @christophebedard
Update launch/launch/substitutions/string_join_substitution.py
54ca555 
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot
Use ld.entities instead of describe_sub_entities as of ros2#857 (comm…
425d0f2 
…ent)

Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot baconbrot force-pushed the stringjoinsubstitution_frontend branch from 207ac0c to 425d0f2 Compare October 21, 2025 11:17
@baconbrot
Update type hints according to ros2#857 (comment) and ros2#857 (comment)
49dee17 


Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
christophebedard
christophebedard reviewed Oct 21, 2025
View reviewed changes
baconbrot and others added 4 commits October 22, 2025 10:51
@baconbrot @christophebedard
Update launch_xml/test/launch_xml/test_string_join_substitution.py
b964aec 
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot @christophebedard
Update launch_xml/test/launch_xml/test_string_join_substitution.py
31274aa 
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot @christophebedard
Update launch_yaml/test/launch_yaml/test_string_join_substitution.py
08ca43d 
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
@baconbrot @christophebedard
Update launch_yaml/test/launch_yaml/test_string_join_substitution.py
2ace3af 
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christian Ruf <c.ruf99@gmail.com>
christophebedard
christophebedard approved these changes Oct 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR and for iterating!

@christophebedard
Copy link
Copy Markdown
Member

christophebedard commented Oct 22, 2025

Pulls: #857
Gist: https://gist.githubusercontent.com/christophebedard/7768144b664ad8346d2dbdf4435877f8/raw/758584283d9fff1279c17971f22279b5daefc834/ros2.repos
BUILD args: --packages-above-and-dependencies launch launch_xml launch_yaml
TEST args: --packages-above launch launch_xml launch_yaml
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17353

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard merged commit 3bd49d6 into ros2:rolling Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees

@baconbrot baconbrot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baconbrot @christophebedard