[foxy backport] Add pytest.ini to test_launch_testing so tests succeed locally. (#431)#451
Merged
jacobperron merged 2 commits intofoxyfrom Aug 18, 2020
Merged
[foxy backport] Add pytest.ini to test_launch_testing so tests succeed locally. (#431)#451jacobperron merged 2 commits intofoxyfrom
jacobperron merged 2 commits intofoxyfrom
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
jacobperron
changed the title
Member
Author
|
@ros-pull-request-builder retest this please |
Member
Author
|
CI for this PR and several other similar backports can be found here: ros2/ci#503 (comment) |
clalancette
requested changes
Aug 18, 2020
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
You are also going to need pytest.ini in the launch_xml, launch, and launch_yaml packages.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
approved these changes
Aug 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #431 to Foxy.
This should help resolve one of the outstanding failures in ros2/ci#503