Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frontend module in launch, launch_xml and launch_yaml packages #226

Merged
merged 75 commits into from
Jul 11, 2019
Merged

Add frontend module in launch, launch_xml and launch_yaml packages #226

merged 75 commits into from
Jul 11, 2019

Commits on Jun 10, 2019

  1. Added launch_fronted abstract entity 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    1090efa View commit details
    Browse the repository at this point in the history

  2. Add launch_xml entity implementation 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    5a894f2 View commit details
    Browse the repository at this point in the history

  3. Add parse_executable function and test 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    3958430 View commit details
    Browse the repository at this point in the history

  4. Corrected with PR comments 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    f23772d View commit details
    Browse the repository at this point in the history

  5. Corrected with PR comments 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    df8c439 View commit details
    Browse the repository at this point in the history

  6. Add expose_action and expose_substitution functions 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    471e406 View commit details
    Browse the repository at this point in the history

  7. Add parser 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    9807d4d View commit details
    Browse the repository at this point in the history

  8. Add interpolate substitution function 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    60e28d0 View commit details
    Browse the repository at this point in the history

  9. Updated xml 'executable' action test. Corrected parser module 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    9e8fac7 View commit details
    Browse the repository at this point in the history

  10. Corrected error checking in decorators 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    43d87c7 View commit details
    Browse the repository at this point in the history

  11. Correct launch_frontend.Entity 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    7a03121 View commit details
    Browse the repository at this point in the history

  12. Load entry_points which add parsing methods 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    e2c50dd View commit details
    Browse the repository at this point in the history

  13. Modified executable example 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    68cba5a View commit details
    Browse the repository at this point in the history

  14. Used parse_substitution in parse_executable 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    4450dd5 View commit details
    Browse the repository at this point in the history

  15. Changed entity 'frontend' staticmethod to a property 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    cc0af6e View commit details
    Browse the repository at this point in the history

  16. Deleted list substitution 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    3ddbe05 View commit details
    Browse the repository at this point in the history

  17. Updated cleaner executable args handling using list 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    4a347fe View commit details
    Browse the repository at this point in the history

  18. Using a grammar for parsing substitutions. Moved to frontend specific… 

    … parsers.

Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    3dd5c31 View commit details
    Browse the repository at this point in the history

  19. Corrected type annotations in substitution_parse_methods 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    2e281f4 View commit details
    Browse the repository at this point in the history

  20. * Updated entity abstraction to allow get typed values. 

    * Updated xml entity with above change.
* Updated action parsing methods.

Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    9d4bca7 View commit details
    Browse the repository at this point in the history

  21. Added yaml launch frontend implementation 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    bf2ad68 View commit details
    Browse the repository at this point in the history

  22. * Replaced map usage with list comprehensions. 

    * Added not found attribute checking for type 'list[Entity]'.

Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    e5a0645 View commit details
    Browse the repository at this point in the history

  23. Corrected xml test_list.py 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    43c77f5 View commit details
    Browse the repository at this point in the history

  24. Updated launch xml readme 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    65871e9 View commit details
    Browse the repository at this point in the history

  25. Added readme to launch_yaml 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    bc2f03c View commit details
    Browse the repository at this point in the history

  26. Add test for let action and var substitution 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    7089121 View commit details
    Browse the repository at this point in the history

  27. Correct bugs in type_utils. Updated related doc. 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    3e1f9e2 View commit details
    Browse the repository at this point in the history

  28. Address PR comments 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    0ba7e9d View commit details
    Browse the repository at this point in the history

  29. Corrected substitution grammar. Completed substitution test 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    f3e08a4 View commit details
    Browse the repository at this point in the history

  30. Add new test substitution case 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    c0efe06 View commit details
    Browse the repository at this point in the history

  31. Update setup.py versions 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    6a30270 View commit details
    Browse the repository at this point in the history

  32. Allow code reusage of base class parsing method 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    ea58a13 View commit details
    Browse the repository at this point in the history

  33. Clearer launch_yaml.Entity constructor 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    51d080e View commit details
    Browse the repository at this point in the history

  34. typo 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    3f13144 View commit details
    Browse the repository at this point in the history

  35. Moved example tests in place 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    595fa9c View commit details
    Browse the repository at this point in the history

  36. Corrected error in type_utils 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    244dbbe View commit details
    Browse the repository at this point in the history

  37. Correct error with brute force load 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    a711306 View commit details
    Browse the repository at this point in the history

  38. Correct indentation 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    f4d7ecc View commit details
    Browse the repository at this point in the history

  39. Add option for reading value as an string in yaml format 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    889dbdb View commit details
    Browse the repository at this point in the history

  40. Revert "Add option for reading value as an string in yaml format" 

    This reverts commit cd4ff85.

Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    7d6076b View commit details
    Browse the repository at this point in the history

  41. Minimal correction in grammar 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    1f6f911 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. Addressed reviewer comments 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    b1e30cd View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Address review comments 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    5cb565c View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. Add parsing function for include and group actions. Added related tests 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    e7d190f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Address per review comments 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    8764df0 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2019

  1. Address review comments 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    be1e683 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2019

  1. Merged launch_frontend into launch package 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    68dc487 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Update type_utils 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    740c204 View commit details
    Browse the repository at this point in the history

  2. Corrected type utils again after further testing 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    f0d0749 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. Delete launch_frontend dependency 

    Signed-off-by: ivan <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    d9a2845 View commit details
    Browse the repository at this point in the history

  2. Update readmes 

    Signed-off-by: ivan <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    75268fc View commit details
    Browse the repository at this point in the history

  3. Test include tag properly 

    Signed-off-by: ivan <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    f8a4b06 View commit details
    Browse the repository at this point in the history

  4. Address PR comments 

    Signed-off-by: ivan <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    a64faaa View commit details
    Browse the repository at this point in the history

  5. Address remaining comments 

    Signed-off-by: ivan <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    fc8b2c8 View commit details
    Browse the repository at this point in the history

  6. Restrict conversions in type_utils 

    Signed-off-by: ivan <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    18cf4a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2019

  1. Correct ExecuteProcess parsing method 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    ecf9a04 View commit details
    Browse the repository at this point in the history

  2. Allow quoted strings in substitution grammar 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    4478603 View commit details
    Browse the repository at this point in the history

  3. Avoid using yaml convertions in type_utils 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    6e52e94 View commit details
    Browse the repository at this point in the history

  4. Renamed launch_frontend folder in test to frontend. Updated test_subs… 

    …titution.py

Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 4, 2019
    Configuration menu
    Copy the full SHA
    5dd0ac0 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Clearer grammar 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    85b39c9 View commit details
    Browse the repository at this point in the history

  2. Update type utils for allowing non uniform lists 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    2e2f5ae View commit details
    Browse the repository at this point in the history

  3. Add a way of escaping the characters as the string passed by the subs… 

    …titution parser

Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    afee3e6 View commit details
    Browse the repository at this point in the history

  4. Correct execute_process method for correctly escape characters 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    ec3ce5c View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2019

  1. Update type_utils in favour of heavy usage of typing objects 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    4b3ecf2 View commit details
    Browse the repository at this point in the history

  2. Correct error in coerce_to_str method 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    38b8c0c View commit details
    Browse the repository at this point in the history

  3. Install grammar.lark correctly 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    efaf9c3 View commit details
    Browse the repository at this point in the history

  4. Solved strange problem when installing grammar.lark when using --syml… 

    …ink-install

Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 8, 2019
    Configuration menu
    Copy the full SHA
    3822fcd View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Please flake8 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    1b73e5d View commit details
    Browse the repository at this point in the history

  2. Avoid using issubclass with typing objects 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    f15b0f2 View commit details
    Browse the repository at this point in the history

  3. Add missing dependency with lark parcer 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    b5f6a95 View commit details
    Browse the repository at this point in the history

  4. Use posix style paths in launch files 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    3c81e11 View commit details
    Browse the repository at this point in the history

  5. Correct type_utils on windows 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    ba9ab09 View commit details
    Browse the repository at this point in the history

  6. Further corrections of type_utils on Windows 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    7b07333 View commit details
    Browse the repository at this point in the history

  7. Solve path problem in test_include 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    091ae9c View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Address review comments 

    Signed-off-by: ivanpauno <[email protected]>
    @ivanpauno
    ivanpauno committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    deada40 View commit details
    Browse the repository at this point in the history