Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated spin_until_future_complete #339

Closed
wants to merge 1 commit into from

Conversation

hliberacki
Copy link

Replace deprecated spin_until_future_complete with spin_until_complete

Signed-off-by: Hubert Liberacki [email protected]

@hliberacki
Copy link
Author

Due to change in RCLCPP - ros2/rclcpp#1874 Pull request

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should avoid unnecessary changes which are irrelevant to this PR.

@hliberacki
Copy link
Author

ros2/rclcpp#1874 (comment) Passing CI with all related PRs linked and build together.

@christophebedard
Copy link
Member

I've opened #376 to replace this PR.

@christophebedard
Copy link
Member

This can be closed, see #376 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants