Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically match QoS settings across the bridge #5

Merged
merged 15 commits into from
Mar 24, 2021
Merged

Automatically match QoS settings across the bridge #5

merged 15 commits into from
Mar 24, 2021

Commits on Mar 10, 2021

  1. [wip] Auto-detect QoS settings 

    Query endpoint info for publishers to get QoS settings before bridging a topic.

TODO: only create bridge once a publisher is detected (use GraphListener).
TODO: integration test (use launch_testing).
Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    b636b3c View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Defer bridging until QoS is available 

    Poll in a thread until a publisher can be queried for QoS settings.

Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    9cd189f View commit details
    Browse the repository at this point in the history

  2. Move thread management into it's own class 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    5d1f2dc View commit details
    Browse the repository at this point in the history

  3. Add more tests 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    d61f298 View commit details
    Browse the repository at this point in the history

  4. Use graph events to trigger check for publishers 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    bbd6431 View commit details
    Browse the repository at this point in the history

  5. Update design doc to reflect implementation 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    e14aaf7 View commit details
    Browse the repository at this point in the history

  6. minor changes to design doc 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    3ac6371 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Fix design doc typos 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    fd1342b View commit details
    Browse the repository at this point in the history

  2. Explicit capture 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    84ae94a View commit details
    Browse the repository at this point in the history

  3. Use map.at accessor instead of operator[] 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    f1bb5c1 View commit details
    Browse the repository at this point in the history

  4. Fix comment 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    c780649 View commit details
    Browse the repository at this point in the history

  5. Handle deadline, lifespan, and liveliness 

    - Always use automatic liveliness
- Use max of deadline policies
- Use max of lifespan policies

Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    c62b3a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Create one thread per domain ID (node) 

    Use a condition variable to notify each thread that a new callback has been registered.

Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    4ae1095 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Fix deadlock bug and handle shutdown race 

    If we get a SIGINT while querying a topic's QoS, then exit cleanly.

Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    eac644d View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Remove vestigial change 

    Signed-off-by: Jacob Perron <[email protected]>
    @jacobperron
    jacobperron committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    b3af55b View commit details
    Browse the repository at this point in the history