Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layered diagrams #121

Closed
wants to merge 2 commits into from
+44 −0
Closed

Layered diagrams #121

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e6aa2
table-based diagram of software layers
tkruse Mar 18, 2017
3fcb53a
Add pseud-code
tkruse Mar 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add pseud-code
@tkruse
tkruse committed Mar 18, 2017
commit 3fcb53aa1f2c6c6fe8e25be35017be5285e21754
8 changes: 8 additions & 0 deletions articles/101_build_tool.md
View file
Original file line number Diff line number Diff line change
@@ -65,6 +65,14 @@ Additionally this makes new features developed for one ROS version / build syste

This phase seems realistic to achieve in predictable time because both catkin_tools and ament_tools already have a large overlap.

A coarse pseudo-code looks like this

1. Detect workspace folder to use (e.g. current folder, or parent folder with marker file, ...)
2. Load workspace adapter for this workspaces buildsystem
3. Ask plugin/wrapper for package declarations (name, folder and dependencies of each package)
4. Create DAG of packages for building the workspace
5. Invoke buildsystem plugin command for each package in build order

### Phase 2 goal: unify workspaces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this article to outline such a phase. The current draft briefly mentions the intrinsic complexity of mixing workspaces like that which are beyond the build tools control: see https://github.com/ros2/design/pull/115/files#diff-361c5cb5b98ec5e7f690f2dbce2cd7fdR186 Also even if all build tools and build systems do the technical part of mixing them well there are other aspects like name spacing of ROS 1 and ROS 2 packages, their rosdep keys, etc. Therefore I think this is exceeding the scope of this article.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the comments of the main PR @wjwwood seems to argue for such a goal #115 (comment), that's why I added it.


| Concept Layer | All ROS / non-ROS |